SkillPedia Skills Encyclopedia
中文 EN
今日更新 2026-11-18 UTC

今天还没有新提交

查看更新动态

技能 2026-10-10 23:09 UTC

skills

由提交人 luongnv89 提交,主要更新类型为:新增功能与能力扩展。提交说明:feat(lstack): add plugin icon for the Claude plugin directory (#415)。带来了新的能力与可配置项,扩展了使用场景。

luongnv89 132152c luongnv89/skills

Commit提交信息原文

feat(lstack): add plugin icon for the Claude plugin directory (#415)

Closes #415

## Description

The Claude plugin directory validator reported **"No icon found in the plugin"**. This adds one:

- `skills/.claude-plugin/icon.png`: 512×512 render of `docs/assets/logo/logo-icon.svg`, placed at a path the validator probes inside the plugin folder (`skills/`).
- The generated `skills/.claude-plugin/plugin.json` now declares `"icon": "./.claude-plugin/icon.png"`, sourced from the `claude` adapter in `packages/lstack/manifest.json`.
- `scripts/build-lstack.py`:
  - accepts an optional `icon` adapter field, limited to `./.claude-plugin/icon.png` or `.svg`
  - `--check-plugin-metadata` fails if the icon file is missing
  - the `--target claude` export copies the icon beside its `plugin.json`, so the exported manifest never points at a missing file
- CHANGELOG entry under `## Unreleased`.

The plugin folder goes from 477 to 478 files (limit 512). The package version stays at 0.5.0; bump it at release.

## Related Issue

Tracked by #415. Addresses Claude plugin directory submission feedback.

## Type of Change

- [ ] New skill
- [ ] Skill enhancement
- [ ] Bug fix
- [ ] Documentation update
- [ ] Refactoring
- [x] Packaging / plugin metadata

## Checklist

- [ ] Skill passes validation (`package_skill.py`): n/a, no SKILL.md changed
- [ ] SKILL.md has proper frontmatter (name, version, description): n/a
- [ ] Description includes trigger phrases: n/a
- [ ] I have tested the skill with an AI agent: n/a
- [ ] README.md updated (if adding new skill): n/a
- [x] Commit messages follow conventional commits

## Testing

- `python3 scripts/build-lstack.py --write-plugin-metadata` then `--check-plugin-metadata`: pass
- `tests/test-lstack-claude-packaging.py` (24 tests, including a new icon export and missing-file test), `tests/test-lstack-codex-packaging.py` (9), `tests/test-lstack-packaging.py` (16): all pass
- `claude plugin validate ./skills`: ✔ Validation passed

## Screenshots (if applicable)

The icon is the existing app tile: a green skill card seated in a white power ring on a dark rounded square.

## Decision Record

- **Root cause:** The plugin directory submission lacked a discoverable listing icon.
- **Options considered:** Supply the existing brand icon as PNG or SVG; omit the icon.
- **Options rejected:** Omitting the icon leaves the directory feedback unresolved; SVG was not selected for this existing 512×512 PNG asset.
- **Selected option:** Include the existing icon, declare it in Claude metadata, validate its presence, and include it in Claude exports.
- **Residual risk:** The shared adapter validator also accepts an icon field for Codex, while its exporter does not copy it. The current Codex adapter declares no icon; this is a non-blocking follow-up.

## Acceptance Criteria Verification

| # | Criterion from #415 | Status | Evidence |
|---|---|---|---|
| 1 | Existing brand icon included; native plugin validation succeeds | pass | 512×512 PNG reviewed; `claude plugin validate --strict ./skills` passed at dfb38d4. |
| 2 | Missing or non-regular declared icons rejected | pass | `native_metadata` rejects missing files and symlinks; `test_adapter_icon_is_copied_beside_exported_manifest` checks the missing-icon error. |
| 3 | Claude export contains its declared icon; packaging tests pass | pass | Icon export regression passed; all 49 packaging tests and `--target claude --check` passed at dfb38d4. |