Skills 2026-10-19 02:58 UTC
nexent
committed by cj2026-bit. Category: Bug Fixes & Stability Improvements. Commit message: 🐛 Fix(e2e): resolve the Daily checkout without the cwd and run the AI….
CommitRaw commit message
🐛 Fix(e2e): resolve the Daily checkout without the cwd and run the AIDP journey on the mock only (#4128) * 🐛 Fix(e2e): pass the checkout explicitly into the Daily preflight Problem: the Ubuntu Daily launcher runs from the GitHub runner workspace while the checkout lives elsewhere; the external-knowledge preflight resolved the repository from the process cwd (repository_root()) and aborted the run with "Cannot locate repository root". A missing profile selection config was also reported as a doctor problem, and Daily refuses to start on any doctor problem. Fix: static_config_problems(home, records, *, repo) receives the checkout as an explicit argument and doctor passes its already-resolved checkout through; nothing resolves a repository from the process working directory any more, and the profile-config gate is gone. One existing onboarding test call site is adapted to the new signature. Verification: tools tests keep exactly the pre-existing 17-failure set (437 passed, no new cases); the 1:1 Daily simulation reproduces the crash on the old revision and runs the fixed revision green (D0-D6, 4/4 PASS). * 🧪 Test(e2e): run the AIDP journey on the mock only and retire the profile selection Problem: there is no real AIDP environment to smoke-test against, so the machine-local config/aidp-journey.yaml selection and the mock/real_smoke profile split were dead weight — one more manual machine-local file whose absence previously gated runs. Solution: PW-KB-AIDP-01 declares required_mock_services [knowledge-provider] directly like its sibling mock cases; the spec runs the fixed seed oracle with no profile env plumbing; ext_attach drops profile resolution and real_smoke export; the validator rejects profile_selection; the example and schema files are deleted; README, case contract and change records updated. Verification: tools tests 437 passed with exactly the pre-existing 17 failures (the profile-selection test class was removed with the mechanism; no new cases added); the asset validator stays green.