Development & Engineering · Intermediate
Code Review
Handing your changes to someone else — or to an AI — to read through, pick out problems and suggest improvements, and merging them into the real project only once nothing serious is wrong. The point is to catch your own blind spots through another pair of eyes.
TL;DRIn 30 seconds
- Hand your changes to someone else to read, pick at and comment on before you decide whether to merge.
- Its whole point is borrowing a second pair of eyes to catch blind spots the author can't see.
- Being told about a problem doesn't mean you're no good — it means the change was read properly.
OverviewIn detail
Code review means the person who wrote the code hands their changes to someone else to look over, asking them to point out problems and suggest improvements, and merging into the real project only once it checks out. It's a manual quality gate: the point isn't running it to see whether it works, but using experience to spot trouble in advance. It scales up and down — for a few lines you might just ask someone to glance at it, but for a substantial chunk it's a gate you have to pass.
You need it because the person who wrote the code has blind spots. Logic you have just finished always reads smoothly to you; someone else often spots a hole, muddled naming, or an edge case left unhandled straight away. Review also does knowledge-sharing as a side effect — if the change causes trouble later, at least one other person knows about it.
More and more, this step is handed to an AI. The usual shape of the interaction is: it reads the change and gives you a handful of comments, and you judge which are worth taking and which can wait. Some teams grade their comments — must fix, worth fixing, open to discussion — so you don't have to treat every one as an order.
Don't treat it as a nitpicking contest. What a comment usually means is 'there might be a problem here', with the aim of digging out trouble early. Being told about a problem doesn't mean you're no good — it means your change got a careful read.
Conversely, nobody objecting doesn't mean there's no problem. How useful a review is depends on whether the reader is willing to spend the time; a quick 'looks fine' sails through fast and stops nothing. To make review actually work, don't make each change too large — hand anyone several hundred lines and they'll skim it.
MythsCommon misunderstandings
- ✕Thinking review is just a formality ✓Whether it's read carefully makes all the difference — a hurried 'looks fine' stops nothing
- ✕Thinking every comment has to be obeyed ✓Comments usually split into must-fix, worth-fixing and open to discussion — you decide what to take
- ✕Thinking no objections means no problems ✓A fast approval usually just means nobody spent real time on it
In practiceWhere you will meet it
- Asking a colleague to look over your change and waiting for their comments before merging
- Having an AI read the change first and list the suspicious spots
- Sorting review comments into what must be fixed and what can wait
SummaryThe key points
- Hand your change to someone to read before merging it into the real project
- Uses a second person's view to catch the author's own blind spots
- An AI often plays the reviewer now, but you still decide what to accept
- Being flagged is proof the change was read with care
FAQ
What does Code Review mean?
Hand your changes to someone else to read, pick at and comment on before you decide whether to merge.Its whole point is borrowing a second pair of eyes to catch blind spots the author can't see.Being told about a problem doesn't mean you're no good — it means the change was read properly.
Where will I run into Code Review?
Asking a colleague to look over your change and waiting for their comments before merging;Having an AI read the change first and list the suspicious spots;Sorting review comments into what must be fixed and what can wait。
What do people most often get wrong about Code Review?
Thinking review is just a formality — but Whether it's read carefully makes all the difference — a hurried 'looks fine' stops nothing;Thinking every comment has to be obeyed — but Comments usually split into must-fix, worth-fixing and open to discussion — you decide what to take。
What are the key points about Code Review?
Hand your change to someone to read before merging it into the real project;Uses a second person's view to catch the author's own blind spots;An AI often plays the reviewer now, but you still decide what to accept;Being flagged is proof the change was read with care。
Common pitfalls No objections doesn't mean no problems — a review waved through stops nothing.
Also written asYou may also see it written as
These are all the same concept — the same thing, however it is written in a skill description. Do not mistake different spellings for different ideas.
Entry 80 of 186 · All entries
Keep readingRelated reading
算法(Algorithm)
算法就是做一件事的固定步骤清单。照着一步步做,同样的输入总能得到同样的结果,电脑就是靠它来完成任务的。
Open Source
Open source means the author publishes the recipe as well as the software. Anyone can read it, use it for free, and even change it and pass it on.
GitHub(代码托管平台)
GitHub 是全球程序员存放和分享代码的网站,既能当作品集,也是大家一起改同一份代码的协作台。
前端(Frontend)
前端是软件里你能看见、能点的那一层。按钮、图片、页面动画,都是它做出来的。
Backend
The backend is the half of the software you never see. Every step you take in the interface is handled behind the scenes by it, looking up data and making the decisions.
Automation
Automation means letting a computer repeat a job by rules you set, so work you would otherwise redo by hand every time is handed over entirely.
Where to go nextExplore more
Back to the skills themselves
Most of the concepts covered here come from skills that install into your AI client with a single command.